[PATCH] D72959: Relative VTables ABI on Fuchsia
Roland McGrath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 2 11:56:02 PDT 2020
mcgrathr added inline comments.
================
Comment at: libcxxabi/src/private_typeinfo.cpp:617
// Get (dynamic_ptr, dynamic_type) from static_ptr
+#ifndef __Fuchsia__
void **vtable = *static_cast<void ** const *>(static_ptr);
----------------
ldionne wrote:
> Please introduce a macro that generically expresses that relative vtables are enabled, and explain what it is. You can then enable that macro only on `__Fuchsia__`. I'd like to avoid freely adding platform-specific `#ifdef`s in the code when it's easy to avoid.
I think the libcxxabi change should be separated from the compiler change entirely.
It will need more configuration issues resolved before it usefully lands.
Let's keep this change just for the pure compiler feature.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72959/new/
https://reviews.llvm.org/D72959
More information about the llvm-commits
mailing list