[PATCH] D76638: [SDAG] fix crash in getNegatedExpression() by ignoring transient fadd
Qing Shan Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 2 10:17:37 PDT 2020
steven.zhang added a comment.
In D76638#1956952 <https://reviews.llvm.org/D76638#1956952>, @spatel wrote:
> Ping. I think this change is useful regardless of whether/how we make a larger fix for getNegatibleCost+getNegatedExpression.
I have posted a patch(https://reviews.llvm.org/D77319) to remove the getNegatibleCost. It is almost ready now. I am not sure if it is the best way , and welcome for the comments in advance. Regarding to the opportunities for this patch, can you double confirm it together with my patch to see if there is any improvement ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76638/new/
https://reviews.llvm.org/D76638
More information about the llvm-commits
mailing list