[PATCH] D76598: [GlobalISel] support narrow G_IMPLICIT_DEF for DstSize % NarrowSize != 0
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 2 09:45:17 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:747
+
+ MI.removeFromBundle();
+ return Legalized;
----------------
gargaroff wrote:
> arsenm wrote:
> > There's no bundle here? Why isn't this just an erase from parent?
> Thanks for spotting! That was just a typo.
Should also be eraseFromParent, not merely remove
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76598/new/
https://reviews.llvm.org/D76598
More information about the llvm-commits
mailing list