[PATCH] D77293: [mlir][DeclarativeParser] Emit an error if a `:` follows an attribute with a non-constant type.

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 09:44:28 PDT 2020


bondhugula added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Affine/IR/AffineOpsBase.td:23
   let returnType = [{ AffineMap }];
+  let valueType = Index;
   let constBuilderCall = "AffineMapAttr::get($0)";
----------------
Shouldn't this be I64? The affine map's results / inputs are Index type, but when the affine map is a constant, that constant is an int64 (and not of index bit width).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77293/new/

https://reviews.llvm.org/D77293





More information about the llvm-commits mailing list