[PATCH] D77280: [ELF] Make --version-script/--dynamic-list work for lazy symbols fetched by LTO libcalls

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 09:12:26 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:123
     for (Symbol *sym : symVector) {
-      if (!sym->isDefined() && !sym->isCommon())
+      if (!sym->isDefined() && !sym->isCommon() && !sym->isLazy())
         continue;
----------------
grimar wrote:
> Seems this change is untested.
This can't be tested because no libcall has a C++ style mangled name.

I did this just for consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77280/new/

https://reviews.llvm.org/D77280





More information about the llvm-commits mailing list