[PATCH] D76140: [InlineFunction] update attributes during inlining

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM again, with minor change.

p.s. Sorry for missing the functional issue the first time.  All of the test changes should have made the issue obvious, but despite reading the LangRef description of signext, I somehow managed to miss the separation between ABI and optimization attributes.



================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1177
+    Valid.addDereferenceableOrNullAttr(DerefOrNullBytes);
+  auto AddAttrWithoutValues =
+      [&](SmallVectorImpl<Attribute::AttrKind> &Kinds) -> void {
----------------
I'm not sure that pulling out the helper for two cases actually helps readability.  Can you drop this and just do the two cases directly please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76140/new/

https://reviews.llvm.org/D76140