[PATCH] D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect

Thu Apr 2 08:39:05 PDT 2020

jasonliu marked an inline comment as done.
jasonliu added inline comments.

================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1849

-      if (TM.getTargetTriple().isOSBinFormatXCOFF()) {
-        cast<MCSymbolXCOFF>(Sym)->setContainingCsect(
----------------
hubert.reinterpretcast wrote:
> Can we expect that `hasCsectMCSectionXCOFF` is true for an undefined XCOFF symbol? Do we want to assert that?
The original purpose of hasCsectMCSectionXCOFF should really be hasCsectMCSectionXCOFFSet. So it won't always be true. I will change the name to hasCsectMCSectionXCOFFSet to avoid confusion. I'm not sure if we really need hasCsectMCSectionXCOFF though, maybe not for this patch until we find the reason that we need to.  

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77080/new/

https://reviews.llvm.org/D77080