[llvm] 07b6c0b - [gn build] remove NOSORT from clang/Headers/BUILD.gn

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 03:21:08 PDT 2020


Author: Nico Weber
Date: 2020-04-02T06:20:13-04:00
New Revision: 07b6c0be4ab7553ff7e8574a794ecc963df0e9c3

URL: https://github.com/llvm/llvm-project/commit/07b6c0be4ab7553ff7e8574a794ecc963df0e9c3
DIFF: https://github.com/llvm/llvm-project/commit/07b6c0be4ab7553ff7e8574a794ecc963df0e9c3.diff

LOG: [gn build] remove NOSORT from clang/Headers/BUILD.gn

Having the sync script work for this file seems better
than matching the order of headers in the cmake file.
Also, not having to manually sort the list is nice, even
if gn's automated sorting doesn't quite match the artisanal
order in the cmake file.

Added: 
    

Modified: 
    llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn

Removed: 
    


################################################################################
diff  --git a/llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn b/llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
index 6994954debb4..005eb740583f 100644
--- a/llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
+++ b/llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
@@ -55,9 +55,6 @@ copy("arm_headers") {
 copy("Headers") {
   deps = [ ":arm_headers" ]
 
-  # NOSORT
-  # Tell `gn format` to not reorder the sources list: Its order matches CMake,
-  # and the ordering is alphabetical but ignores leading underscores.
   sources = [
     "arm_cmse.h",
     "adxintrin.h",


        


More information about the llvm-commits mailing list