[PATCH] D76836: [AMDGPU] Add G16 support to image instructions

[Sebastian Neubauer via Phabricator via llvm-commits]

Flakebi added a comment.

What is the best way to handle A16 and G16 in instruction selection for GlobalISel?

They are only encoded in the types of arguments and not in the intrinsic id. In legalization, we can simply check the type of derivative and address arguments but afterwards, all arguments are packed into a singe, large value for the non-nsa case or several 32 bit values for nsa.
I think it’s hard to detect if this was originally A16 or even only G16 with 32 bit addresses.

Should I encode this information into metadata in the legalization step and use that in instruction selection?

I think this would look like `I.getMetadata("amdgpu.a16")` and `I.getMetadata("amdgpu.g16")`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76836/new/

https://reviews.llvm.org/D76836