[PATCH] D77218: [Alignment][NFC] Mark IRTranslator::getMemOpAlignment deprecated

Thu Apr 2 02:08:47 PDT 2020

gchatelet marked 2 inline comments as done.
gchatelet added inline comments.

================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/IRTranslator.h:585-589
+  LLVM_ATTRIBUTE_DEPRECATED(
+      inline unsigned getMemOpAlignment(const Instruction &I),
+      "Use getMemOpAlign instead") {
     return getMemOpAlign(I).value();
   }
----------------
arsenm wrote:
> The number of uses in GlobalISel is so small, there's no reason to bother with this. It should be trivial to eliminate the old forms
Are you sure it's not used by out of tree users?
If so, I'm happy to drop it.

My plan is to start removing `LLVM_ATTRIBUTE_DEPRECATED` functions that have been introduced in the last release.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77218/new/

https://reviews.llvm.org/D77218