[PATCH] D77285: [llvm-objdump][NFC] Split format-specific interfaces; add namespace

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with or without my comments addressed.



================
Comment at: llvm/tools/llvm-objdump/COFFDump.h:13
+#include "llvm/ADT/SmallVector.h"
+#include "llvm/Support/Error.h"
+
----------------
Can't you forward-declare `Error` to avoid this include?


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:49
 #include "llvm/Object/ObjectFile.h"
 #include "llvm/Object/XCOFFObjectFile.h"
 #include "llvm/Object/Wasm.h"
----------------
It's probably okay to address this clang-format comment here, since you're adding a new include.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77285/new/

https://reviews.llvm.org/D77285