[PATCH] D76954: LLVM support for BB-cluster sections

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:583
+  auto Before = std::next(getReverseIterator());
+  return (Before == MF->rend()) || (Before->getSectionID() != getSectionID());
 }
----------------
I don't have a strong opinion but the fact that this is being computed for every call of isBeginSection and isEndSection makes me a bit nervous.  Why do this when BBSectionsPrepare can just set  a bool? can always be done later if there are many calls to these functions, just putting it out here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76954/new/

https://reviews.llvm.org/D76954