[PATCH] D77286: [mlir] Enable fusion on conv op if it is a consumer.

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula requested changes to this revision.
bondhugula added a comment.
This revision now requires changes to proceed.

Could you add a test case?



================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp:140
 
+// Fuse the `producer` into `consumer`. The `producer` will be tiled base on
+// the subview of the operand in consumer.
----------------
Doc comment ///


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp:154
-  if (auto convOp = dyn_cast<linalg::ConvOp>(consumer.getOperation())) {
-    // TODO(ntv): add a level of indirection to linalg.generic.
-    if (convOp.padding())
----------------
You've also removed this TODO comment - check if it's still applicable. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77286/new/

https://reviews.llvm.org/D77286