[PATCH] D76958: [test-suite] Add support for Hexagon
Brian Cain via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 1 21:46:45 PDT 2020
bcain reclaimed this revision.
bcain marked an inline comment as done.
bcain added inline comments.
================
Comment at: MicroBenchmarks/libs/benchmark-1.3.0/src/cycleclock.h:85
return (high << 32) | low;
+#elif defined(__hexagon__)
+ uint64_t retv;
----------------
lebedev.ri wrote:
> bcain wrote:
> > lebedev.ri wrote:
> > > Can you please submit this as a pull request upstream?
> > Oh, you bet! I didn't know we could use PRs.
> >
> > There's been a few threads and I've only skimmed them. Now that you mention it I might've seen one that mentioned test-suite and PRs.
> I'm not sure what you mean.
> I was only talking about `MicroBenchmarks/libs/benchmark-1.3.0/*` change,
> about upstreaming it to https://github.com/google/benchmark
Oh, whoops! Jumped the gun there.
Ok, will do. Once it lands there, do I make another review here to pull down the next release of that `benchmark`? Or does that happen naturally somehow?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76958/new/
https://reviews.llvm.org/D76958
More information about the llvm-commits
mailing list