[PATCH] D77228: [AMDGPU] Disable 'Skip Uniform Regions' optimization by default; add support for -opt-bisect-limit; update tests.

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 19:37:13 PDT 2020


sameerds added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/StructurizeCFG.cpp:977
 bool StructurizeCFG::runOnRegion(Region *R, RGPassManager &RGM) {
-  if (R->isTopLevelRegion())
+  if (skipRegion(*R) || R->isTopLevelRegion())
     return false;
----------------
This seems to be related to opt-bisect, and should go into a different commit. I am also not sure how this will work. There wouldn't be any guarantee of producing valid ISA if the structurizer skipped entire regions during a bisect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77228/new/

https://reviews.llvm.org/D77228





More information about the llvm-commits mailing list