[PATCH] D76902: [PowerPC][AIX] ByVal formal argument support: multiple registers

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7109
+        if (!ArgLocs[I].isRegLoc())
+          report_fatal_error("Passing ByVals split between registers and stack "
+                             "not yet implemented.");
----------------
The first ArgLoc could be a mem loc, in which case the error is a bit odd.  I think it's sufficient to use "Passing ByVals on the stack is not yet implemented."  Change or leave it at your discretion.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7113
+               "Expecting more RegLocs for ByVal argument.");
+        assert(I != End &&
+               "Expecting enough RegLocs to copy entire ByVal arg.");
----------------
I think this assertion is redundant to the assertion that will occur on ArgLocs[I] anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76902/new/

https://reviews.llvm.org/D76902