[PATCH] D77130: [DAG] Change isGCValue detection for statepoint lowering

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 19:37:08 PDT 2020


reames requested changes to this revision.
reames added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp:486
+  auto isGCValue = [&](const Value *V) {
+    // Conservatively suggest hat any pointer is GC one.
+    return V->getType()->isPtrOrPtrVectorTy();
----------------
Minor improvement:
if (V->getType()->isPtrOrPtrVectorTy()) {
  if (auto IsManaged = GFI->getStrategy().isGCManagedPointer(Ty))
    return *IsManaged;
 return true; // conservative
}



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77130/new/

https://reviews.llvm.org/D77130





More information about the llvm-commits mailing list