[PATCH] D77122: [DOC] Remove too strong restriction for ‘llvm.experimental.gc.statepoint’ Intrinsic
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 1 19:37:08 PDT 2020
reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
LGTM w/required change.
================
Comment at: llvm/docs/Statepoints.rst:525
The 'deopt parameters' arguments contain an arbitrary list of Values
which is meaningful to the runtime. The runtime may read any of these
+values, but is assumed not to modify them until the garbage collector
----------------
Just drop this sentence:
"The runtime may read any of these values, but is assumed not to modify them until the garbage collector might need to modify one of these values. "
It's tempting to try to describe the interaction around stack slots shared between deopt and GC values here, but I couldn't find wording which wasn't simply confusing in a different way. For the moment, let's just leave that aspect undocumented.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77122/new/
https://reviews.llvm.org/D77122
More information about the llvm-commits
mailing list