[PATCH] D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 16:54:33 PDT 2020


MaskRay added a comment.

In D76885#1955969 <https://reviews.llvm.org/D76885#1955969>, @phosek wrote:

> I think the removal of `--thread` could have been handled more gracefully, e.g. print a warning but retain the existing functionality, and later follow up with the removal. Right now our only options are to either disable threading until we roll the new toolchain and slow down the build in the meantime, or disable the canary bots and loose coverage for upstream changes, neither of which is great.


--threads was the default so you can just delete it from your BUILD.gn There is no functional difference before or after this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76885/new/

https://reviews.llvm.org/D76885





More information about the llvm-commits mailing list