[PATCH] D77106: [cmake] Only set deps for an ExternalProject if the type is executable or library

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 16:54:32 PDT 2020


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Sure, works for me.

Might be worth adding a comment that this is mirroring logic in CMake, and that CMake 3.17+ error out if you try to use `$<TARGET_FILE:...>` on an unsupported target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77106/new/

https://reviews.llvm.org/D77106





More information about the llvm-commits mailing list