[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D77227#1955859 <https://reviews.llvm.org/D77227#1955859>, @probinson wrote:

> In D77227#1955808 <https://reviews.llvm.org/D77227#1955808>, @jdenny wrote:
>
> > I agree we don't want these diagnostics to examine FileCheck prefixes within RUN lines.  I was just observing that the rule as I formulated it above would be sufficient for that purpose, so we wouldn't need a separate constraint for RUN lines.
>
>
> Ah, so I misunderstood what you meant by "the above rule" sorry about that!  If we require a comment marker to precede the directive, then we're good (until some clever language decides to use '=' as their comment delimiter).


I would also like to keep FileCheck usable outside of LLVM since I think it's a valuable tool. Therefore it's nice if we can indeed not special case RUN lines which it seems we can.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227