[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 15:45:47 PDT 2020


arsenm added inline comments.


================
Comment at: clang/test/CodeGen/thinlto-distributed-newpm.ll:110
 ; CHECK-O: Running analysis: OuterAnalysisManagerProxy
-; CHECK-O: Running pass: SpeculativeExecutionPass on main
+; CHECK-O: Running pass: SpeculativeExecutionIfHasBranchDivergencePass on main
 ; CHECK-O: Running pass: JumpThreadingPass on main
----------------
The pass name shouldn't change here?


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:435
   if (Level.getSpeedupLevel() > 1) {
-    FPM.addPass(SpeculativeExecutionPass());
+    FPM.addPass(SpeculativeExecutionIfHasBranchDivergencePass());
 
----------------
I don't expect this to be a separate pass, just added based on a divergent target


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76389/new/

https://reviews.llvm.org/D76389





More information about the llvm-commits mailing list