[PATCH] D76611: [SCCP] Use ranges for predicate info conditions.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 1 14:13:47 PDT 2020
fhahn added a comment.
In D76611#1955626 <https://reviews.llvm.org/D76611#1955626>, @efriedma wrote:
> Code looks fine.
>
> I'm a little concerned that the recent clarification in LangRef doesn't actually match the code at the moment, so this could end up exposing an issue with some other transform. (grep for Attribute::SanitizeMemory.)
I assume you are referring to code in other passes, right? I think we probably have code assuming both the new behaviour and the old one and we somehow have to consolidate the code base. Probably best to discuss that at the langref change/llvm-Dev?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76611/new/
https://reviews.llvm.org/D76611
More information about the llvm-commits
mailing list