[PATCH] D66564: [clang-tidy] new altera struct pack align check

[Frank Derry Wanye via Phabricator via llvm-commits]

ffrankies updated this revision to Diff 254277.
ffrankies added a comment.

Addressed comments by @aaron.ballman

You're right, we don't want this to trigger on template instantiations and structs declared in system headers.

- Check no longer triggers on template instantiations
- Check no longer triggers on structs declared in system headers

To add to @Eugene.Zelenko's comment: there are 5 patches for the `altera` module including this one (D72235 <https://reviews.llvm.org/D72235>, D72218 <https://reviews.llvm.org/D72218>, D72241 <https://reviews.llvm.org/D72241>, and D70094 <https://reviews.llvm.org/D70094>). We also have 2 checks that have been put on the backlog due to time/funding constraints, but could be resurrected if that changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66564/new/

https://reviews.llvm.org/D66564

Files:
  clang-tools-extra/clang-tidy/CMakeLists.txt
  clang-tools-extra/clang-tidy/ClangTidyForceLinker.h
  clang-tools-extra/clang-tidy/altera/AlteraTidyModule.cpp
  clang-tools-extra/clang-tidy/altera/CMakeLists.txt
  clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp
  clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.h
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/altera-struct-pack-align.rst
  clang-tools-extra/docs/clang-tidy/checks/list.rst
  clang-tools-extra/docs/clang-tidy/index.rst
  clang-tools-extra/test/clang-tidy/checkers/altera-struct-pack-align.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66564.254277.patch
Type: text/x-patch
Size: 20141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200401/46f746c4/attachment.bin>