[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 1 12:36:55 PDT 2020
jdenny added a comment.
In D77227#1955428 <https://reviews.llvm.org/D77227#1955428>, @probinson wrote:
> While FileCheck allows a CHECK directive anywhere, in practice people always put them at the start of a line with possibly comment delimiters of some form in front (which are always punctuation marks of some kind, in the languages that FileCheck supports). Maybe FileCheck should say, that's where directives *have* to be. Are there real tests where that would be a problem?
I just tried this in `clang/test`:
$ git grep '[a-zA-Z0-9].*// CHECK'
1543
Eyeballing it, they're mostly legitimate FileCheck directives.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77227/new/
https://reviews.llvm.org/D77227
More information about the llvm-commits
mailing list