[PATCH] D77182: [AddressSanitizer] Fix for wrong argument values appearing in backtraces

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 11:15:00 PDT 2020


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:3003
+    auto *Alloca = dyn_cast<AllocaInst>(Store->getPointerOperand());
+    if (!Alloca || ASan.isInterestingAlloca(*Alloca))
+      continue;
----------------
It's counterintuitive that this isn't `!isInterestingAlloca()`. Perhaps commen why we skip the interesting ones?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77182/new/

https://reviews.llvm.org/D77182





More information about the llvm-commits mailing list