[PATCH] D76928: [InstCombine][X86] Simplify demanded elts in SSE intrinsics with repeated args (PR24523)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 09:53:32 PDT 2020


spatel added a comment.

In D76928#1955125 <https://reviews.llvm.org/D76928#1955125>, @spatel wrote:

> 4. Improve demanded elements analysis of x86 min/max/cmp - the x86 part of this patch, but with different tests to show the win with different operands.


On 2nd thought, I doubt there will be anything left to do for this if the other patches are in place...

> The first 3 are independent/parallel. The first 2 raise a potential problem that I don't know the answer to: what happens to target-specific intrinsics in a strict FP environment? Do we need to bypass the folds in that case? Is there some existing code that we can look at that deals with that situation?

I think that this is an existing problem based on the similar demand-based simplifications near the code diff in this patch and transforms in InstCombiner::visitCallInst(), so those patches don't need to be gated on an answer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76928/new/

https://reviews.llvm.org/D76928





More information about the llvm-commits mailing list