[PATCH] D77033: [Legalizer] Workaround for scalarizing unary strict-fp ops

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 09:53:30 PDT 2020


qiucf planned changes to this revision.
qiucf marked an inline comment as done.
qiucf added a comment.

Add tests based on revision D64193 <https://reviews.llvm.org/D64193>.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:229
+                         DAG.getVectorIdxConstant(0, dl));
+    }
+    Opers[1] = Oper;
----------------
cameron.mcinally wrote:
> Can this if-else be rolled into the generic loop below? Or is there a reason that's not ok?
That's because every strict-fp operation will have extra operand at first position for chain. While `ScalarizeVecRes_UnaryOp` just takes the first operand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77033/new/

https://reviews.llvm.org/D77033





More information about the llvm-commits mailing list