[PATCH] D77082: [AMDGPU] Handle SMRD signed offset immediate
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 1 09:53:29 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1798
- if (Gen == AMDGPUSubtarget::SEA_ISLANDS) {
- EncodedOffset =
- AMDGPU::getSMRDEncodedLiteralOffset32(*Subtarget, ByteOffset);
- if (EncodedOffset) {
- Offset = CurDAG->getTargetConstant(*EncodedOffset, SL, MVT::i32);
- return true;
- }
+ if (!CurDAG->SignBitIsZero(ByteOffsetNode))
+ return false;
----------------
The GlobalISel patch seems to be missing this part?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77082/new/
https://reviews.llvm.org/D77082
More information about the llvm-commits
mailing list