[PATCH] D77200: [LLD][ELF][ARM] use reloc directive for Thumb assembler tests

Wed Apr 1 08:27:58 PDT 2020

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.

> use reloc directive for Thumb assembler tests

Maybe `reloc` -> `.reloc`

> I noticed that .reloc wasn't behaving well when an Alignment or Padding fragment had been inserted. I've replaced the few inline .balign directives with nops in this case. Will need to look into MC and raise a PR if there is a problem.

I can't find where nops are used...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77200/new/

https://reviews.llvm.org/D77200