[PATCH] D77181: [WebAssembly] Fix subregion relationship in CFGSort

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 08:14:51 PDT 2020


aheejin marked 2 inline comments as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyCFGSort.cpp:99
+    // excptions), but MachineLoop may not, because MachineLoop does not contain
+    // BBs that don't have a pass to its header even if they are dominated by
+    // its header. So here we should use WE->contains(ML->getHeader()), but not
----------------
dschuff wrote:
> do you mean "path" instead of "pass" here and in the commit message?
Thanks, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77181/new/

https://reviews.llvm.org/D77181





More information about the llvm-commits mailing list