[PATCH] D77216: [llvm-readobj] - Fix crashes and misbehaviors when reading strings from broken string tables.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 08:14:48 PDT 2020


grimar added a comment.

In D77216#1954873 <https://reviews.llvm.org/D77216#1954873>, @jhenderson wrote:

> Hmmm... my first instinct here is that we should print a single warning out-of-line, and then use the "<?>" pattern in place of the invalid strings. That probably goes for the existing messages too. What do you think about that idea?


Yeah, I've though about that we might want to change the code to this behavior as it would be more consistent with all kinds of other errors we have.
I'll prepare a patch to change the existent behavior first then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77216/new/

https://reviews.llvm.org/D77216





More information about the llvm-commits mailing list