[PATCH] D74453: [LegalizeTypes][RISCV] Correctly sign-extend comparison for ATOMIC_CMP_XCHG

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 marked 2 inline comments as done.
jrtc27 added a comment.

In D74453#1931264 <https://reviews.llvm.org/D74453#1931264>, @luismarques wrote:

> Hey @jrtc27 . Is there anything blocking this patch being committed?


No, I forgot about this/was busy with other things and this got neglected. Now committed.



================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:1880
+  /// value to be extended (ZERO_EXTEND, SIGN_EXTEND, or ANY_EXTEND).
+  virtual ISD::NodeType getExtendForAtomicCmpSwapArg() const {
+    return ISD::ANY_EXTEND;
----------------
efriedma wrote:
> Please add an explanation for why this needs to be separate from getExtendForAtomicOps.
Added in committed version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74453/new/

https://reviews.llvm.org/D74453