[PATCH] D77101: [AIX] Return the correct set of callee saved regs

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

Change looks good, however there is a couple things complicating this.

1. The SplitCSR code is dead with Darwins removal and we didn't realize it.
2. `CSR_AIX64` and `CSR_SVR464` are the same and should be one list, not 2 distinct lists.

Usually I would suggest we land 2 NFC patches to clean this up first, however I don't want to delay this bugfix for te removal of dead code.

If no one else objects, I would suggest:

1. Condensing the SVR464 and AIX64 lists to a single list and removing the Darwin lists in an NFC patch.
2. Updating this patch to: keep the fatal error you added for `AnyReg` calling convention, then handling isOSAIX() immediately after, with a fatal error if the calling convention  is ColdCC.

That avoids changing the SplitCSR code which makes it look like its still alive for SVR4 ABIs.  We can then remove SplitCSR in a follow up NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77101/new/

https://reviews.llvm.org/D77101