[PATCH] D77147: [llvm-readobj] - Do not crash when SHT_HASH table is broken.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 03:51:05 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/hash-histogram.test:122
+
+# ERR1: warning: '[[FILE]]': the hash table at offset 0x2b1 goes past the EOF (0x2b8){{$}}
+
----------------
jhenderson wrote:
> I'd spell out "EOF" in error messages (i.e. "goes past the end of the file"). Same goes below.
Ok. My motivation was to make error messages shorter, but I have no preference and I've expected to get a comment like this too :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77147/new/

https://reviews.llvm.org/D77147





More information about the llvm-commits mailing list