[PATCH] D77089: [CallSiteSplitting] Simplify isPredicateOnPHI & continue checking PHIs.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/CallSiteSplitting.cpp:437
+        continue;
+      if (isa<Constant>(PN.getIncomingValue(0)) &&
+          isa<Constant>(PN.getIncomingValue(1)))
----------------
davidxl wrote:
> Should this be relaxed too -- allow splitting when there is one constant value?
I think we could , given that we also split if we find an argument only to be constant in one predecessor due to a condition. But I think that might be better done as a potential follow-up?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77089/new/

https://reviews.llvm.org/D77089