[PATCH] D77201: [CodeGen][SelectionDAG] Flip Booleans More Often

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 02:43:50 PDT 2020


RKSimon added a comment.

Please update your description - you're not explaining the mechanics of your change at all.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2594
+
+  ConstantSDNode *Const = isConstOrConstSplat(V.getOperand(1), false, true);
   if (!Const)
----------------
Might be a good idea to tag the bools here:
```
isConstOrConstSplat(V.getOperand(1), /*AllowUndefs*/false, /*AllowTruncation*/true)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77201/new/

https://reviews.llvm.org/D77201





More information about the llvm-commits mailing list