[PATCH] D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 1 02:43:49 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with two more reportError -> reportWarning changes.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2738
+ if (Error E = ARMAttributeParser(&W).parse(Contents, support::little))
+ reportError(std::move(E), ObjF->getFileName());
+ } else if (Machine == EM_RISCV) {
----------------
As with the case you've modified, please change this to `reportWarning` and then return/continue as appropriate.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2741
+ if (Error E = RISCVAttributeParser(&W).parse(Contents, support::little))
+ reportError(std::move(E), ObjF->getFileName());
+ }
----------------
Ditto.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75833/new/
https://reviews.llvm.org/D75833
More information about the llvm-commits
mailing list