[PATCH] D77052: [MLIR] Rename collapsePLoops -> collapseParallelLoops

[Theodore Popp via Phabricator via llvm-commits]

tpopp marked 2 inline comments as done.
tpopp added inline comments.
Herald added a subscriber: grosul1.


================
Comment at: mlir/lib/Transforms/Utils/LoopUtils.cpp:1202
   OpBuilder builder(outer);
-  OpBuilder innerBuilder(inner.getBody(), inner.getBody()->begin());
+  OpBuilder innerBuilder(inner.region());
   auto loopPieces =
----------------
tpopp wrote:
> bondhugula wrote:
> > `inner.getBody()` to avoid confusion since this is a single block region.
> I'll block this on whatever happens with https://reviews.llvm.org/D77060
> 
> There's an annoying detail right now that constructing an OpBuilder on a Block vs Region create different insertion points (end() and begin()) respectively, so I'll revert this line and another below if it resolves in a different way, or do as you suggest here if it lands.
This is now `OpBuilder::atBlockBegin()` in order to be more explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77052/new/

https://reviews.llvm.org/D77052