[PATCH] D77146: [DebugInfo] Fix reading location tables headers of v5 units in DWP.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 1 01:03:55 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Looks good to me, although I'm not fully up to speed on .debug_loclists to be 100% certain, so might be worth a second opinion.
What did the code do before? Parse the first one repeatedly?
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:541-542
Offset -= HeaderSize;
+ if (auto *IndexEntry = Header.getIndexEntry())
+ if (const auto *C = IndexEntry->getOffset(DW_SECT_LOCLISTS))
+ Offset += C->Offset;
----------------
Maybe these shouldn't be `auto`? Certainly, `C` looks like it should be a number (e.g. uint64_t), but it obviously isn't.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77146/new/
https://reviews.llvm.org/D77146
More information about the llvm-commits
mailing list