[PATCH] D77087: [lld-macho] Require executables to link against libSystem.dylib

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 20:55:04 PDT 2020


int3 added a comment.

I wasn't talking about cross-building; I just thought upstream had an expectation that the test suite would run on non-macOS platforms as well. If the tests are to pass on other platforms, then we can't pass `-lSystem.B` when invoking lld, which means that the resulting binaries in the `Outputs` folder wouldn't be executable on macOS -- and being able to execute them locally has been really useful for checking my assumptions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77087/new/

https://reviews.llvm.org/D77087





More information about the llvm-commits mailing list