[PATCH] D77086: [lld-macho][easy] Use substitution for test
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 31 20:23:02 PDT 2020
ruiu added a comment.
In D77086#1953958 <https://reviews.llvm.org/D77086#1953958>, @int3 wrote:
> Manual line wrapping is kind of a chore, and since we don't have an autoformatter for these files, we'd end up with lines that are too short after doing that `sed` operation. Plus I was also considering adding `-Z` to the base `%lld` substitution to ensure that we never write tests which accidentally depend on system libraries.
We are not strictly enforcing the 80 column rule to the test files, so having long lines are fine for now.
Regarding `-Z`, shouldn't we turn on that flag whenever LLD_IN_TEST environment variable is set? It's the catch-all flag to change the linker's behavior whenever running in the test environment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77086/new/
https://reviews.llvm.org/D77086
More information about the llvm-commits
mailing list