[PATCH] D76977: [lld-macho] Implement basic export trie
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 31 19:50:42 PDT 2020
int3 marked an inline comment as done.
int3 added inline comments.
================
Comment at: lld/MachO/ExportTrie.cpp:75
+
+void TrieNode::addSymbol(const Symbol &entry,
+ std::vector<TrieNode *> &allNodes) {
----------------
ruiu wrote:
> `addSymbol` seem to keep the internal trie consistent all the time, but I don't think we need to split the work between `addSymbol` and `build`. We can make `addSymbol` just to store an argument to an array, and move the code for trie construction to `build`.
Not sure I understand what you're going for. Do you mean to have TrieBuilder::addSymbol collect the symbols to export in a vector, and then have `build()` call `TrieNode::addSymbol()` for all the symbols right before serializing the trie?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76977/new/
https://reviews.llvm.org/D76977
More information about the llvm-commits
mailing list