[PATCH] D76908: [lld-macho] Add support for emitting dylibs with a single symbol

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 18:12:52 PDT 2020


int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:148-150
+    case OPT_install_name:
+      config->installName = arg->getValue();
+      break;
----------------
ruiu wrote:
> Do you have to process this option in a for loop? It looks like you can do somethin glike
> 
>   config->outputFile = args.getLastArgValue(OPT_o, "a.out");
>   config->installName = args.getLastArgValue(OPT_install_name, config->outputFile);
Oh, that's indeed nicer. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76908/new/

https://reviews.llvm.org/D76908





More information about the llvm-commits mailing list