[PATCH] D76252: [lld-macho] Add basic support for linking against dylibs

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.h:33
+  void writeTo(uint8_t *buf) override {
+    // Nothing to write, GOT starts as all zeroes
+  }
----------------
ruiu wrote:
> So GOT has no data but dynamic relocations? If so, I'd leave a brief comment here.
Actually, I'm not sure it's right to say that it has "no data" -- it does actually occupy space in the binary (unlike the __PAGEZERO segment, a section can't have zero filesize while having a non-zero-length address range), so I think saying it contains all zeroes is more accurate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76252/new/

https://reviews.llvm.org/D76252