[PATCH] D76414: [mlir][Linalg] Introduce linalg.pooling_min/max/sum op.

[Han-Chung Wang via Phabricator via llvm-commits]

hanchung added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td:500
+        };
+    }
+  }];
----------------
nicolasvasilache wrote:
> hanchung wrote:
> > mehdi_amini wrote:
> > > This is quite a block of C++, can you move this all out of ODS?
> > I'm following other ops style here. I'm happy to move all of them out of ODS, but can we keep it as this way for now?
> > 
> > Nicolas, do you have any comment/suggestion here?
> A lot of these things will be auto-generated soon.
> I have been personally moving things out of C++ and into Tablegen to reduce the number of places we need to modify.
> I don't have a particular suggestion. 
This might should be auto-generated. Let's keep it this way, I'm happy to help on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76414/new/

https://reviews.llvm.org/D76414