[PATCH] D77104: [mlir] Add a pre-check before checking constraints of an optional attribute.

Han-Chung Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 15:27:29 PDT 2020


hanchung abandoned this revision.
hanchung added a comment.

Had a quick chat with @antiagainst , this is too aggressive. A proper fix might be using isa_and_nonnull for optional attribute.

With Lei's suggestion, this no longer blocks me. I'm going to close the patch. Thank you, Lei. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77104/new/

https://reviews.llvm.org/D77104





More information about the llvm-commits mailing list