[PATCH] D77160: Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping

Andrew J Wock via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 13:48:00 PDT 2020


ajwock accepted this revision.
ajwock added a comment.
This revision is now accepted and ready to land.

LGTM, just give the test a good name.



================
Comment at: llvm/test/Transforms/SeparateConstOffsetFromGEP/pr45371.ll:6
+
+define void @PR45371() {
+; CHECK-LABEL: @PR45371(
----------------
Can we have a name for this file and this function that's a little more self explanatory?  If it weren't attached to this commit I would have no idea what's being tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77160/new/

https://reviews.llvm.org/D77160





More information about the llvm-commits mailing list