[PATCH] D73306: llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number.
Richard Smith - zygoloid via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 31 13:07:41 PDT 2020
rsmith updated this revision to Diff 253973.
rsmith marked 6 inline comments as done.
rsmith added a comment.
- Explicitly check for failed lookup in tests to differentiate between success and errors.
- Fix test expectations for 0O prefix, which is not supported by llvm-symbolizer nor llvm-addr2line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73306/new/
https://reviews.llvm.org/D73306
Files:
llvm/docs/CommandGuide/llvm-addr2line.rst
llvm/test/lit.cfg.py
llvm/test/tools/llvm-symbolizer/input-base.test
llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73306.253973.patch
Type: text/x-patch
Size: 7012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200331/e28885d5/attachment.bin>
More information about the llvm-commits
mailing list