[PATCH] D77163: libclc: Use echo rather than true for try_compile

[Daniel Stone via Phabricator via llvm-commits]

daniels created this revision.
daniels added reviewers: jvesely, tstellar.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.

When providing a fake compiler, libclc currently uses 'true' which does
not exist on Windows. Use echo instead as the no-op.

Depends on: D77162 <https://reviews.llvm.org/D77162>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77163

Files:
  libclc/cmake/CMakeTestCLCCompiler.cmake
  libclc/cmake/CMakeTestLLAsmCompiler.cmake


Index: libclc/cmake/CMakeTestLLAsmCompiler.cmake
===================================================================
--- libclc/cmake/CMakeTestLLAsmCompiler.cmake
+++ libclc/cmake/CMakeTestLLAsmCompiler.cmake
@@ -24,7 +24,7 @@
   try_compile(CMAKE_LLAsm_COMPILER_WORKS ${CMAKE_BINARY_DIR}
     ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/testLLAsmCompiler.ll
     # We never generate executable so bypass the link step
-    CMAKE_FLAGS -DCMAKE_LLAsm_LINK_EXECUTABLE='true'
+    CMAKE_FLAGS -DCMAKE_LLAsm_LINK_EXECUTABLE='echo'
     OUTPUT_VARIABLE __CMAKE_LLAsm_COMPILER_OUTPUT)
   # Move result from cache to normal variable.
   set(CMAKE_LLAsm_COMPILER_WORKS ${CMAKE_LLAsm_COMPILER_WORKS})
Index: libclc/cmake/CMakeTestCLCCompiler.cmake
===================================================================
--- libclc/cmake/CMakeTestCLCCompiler.cmake
+++ libclc/cmake/CMakeTestCLCCompiler.cmake
@@ -24,7 +24,7 @@
   try_compile(CMAKE_CLC_COMPILER_WORKS ${CMAKE_BINARY_DIR}
     ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}/CMakeTmp/testCLCCompiler.cl
     # We never generate executable so bypass the link step
-    CMAKE_FLAGS -DCMAKE_CLC_LINK_EXECUTABLE='true'
+    CMAKE_FLAGS -DCMAKE_CLC_LINK_EXECUTABLE='echo'
     OUTPUT_VARIABLE __CMAKE_CLC_COMPILER_OUTPUT)
   # Move result from cache to normal variable.
   set(CMAKE_CLC_COMPILER_WORKS ${CMAKE_CLC_COMPILER_WORKS})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77163.253965.patch
Type: text/x-patch
Size: 1382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200331/fd51ab9d/attachment-0001.bin>